Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix a windows UI bug. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/callback_forward.h" 9 #include "base/callback_forward.h"
10 #include "chrome/browser/lifetime/application_lifetime.h" 10 #include "chrome/browser/lifetime/application_lifetime.h"
(...skipping 14 matching lines...) Expand all
25 class LocationBar; 25 class LocationBar;
26 class Profile; 26 class Profile;
27 class StatusBubble; 27 class StatusBubble;
28 class TabContents; 28 class TabContents;
29 typedef TabContents TabContentsWrapper; 29 typedef TabContents TabContentsWrapper;
30 class TemplateURL; 30 class TemplateURL;
31 #if !defined(OS_MACOSX) 31 #if !defined(OS_MACOSX)
32 class ToolbarView; 32 class ToolbarView;
33 #endif 33 #endif
34 34
35 namespace autofill {
36 class PasswordGenerator;
37 }
35 namespace content { 38 namespace content {
36 class WebContents; 39 class WebContents;
37 struct NativeWebKeyboardEvent; 40 struct NativeWebKeyboardEvent;
38 struct SSLStatus; 41 struct SSLStatus;
39 } 42 }
40 43
41 namespace extensions { 44 namespace extensions {
42 class Extension; 45 class Extension;
43 } 46 }
44 47
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 375
373 // Shows the avatar bubble inside |web_contents|. The bubble is positioned 376 // Shows the avatar bubble inside |web_contents|. The bubble is positioned
374 // relative to |rect|. |rect| should be in the |web_contents| coordinate 377 // relative to |rect|. |rect| should be in the |web_contents| coordinate
375 // system. 378 // system.
376 virtual void ShowAvatarBubble(content::WebContents* web_contents, 379 virtual void ShowAvatarBubble(content::WebContents* web_contents,
377 const gfx::Rect& rect) = 0; 380 const gfx::Rect& rect) = 0;
378 381
379 // Shows the avatar bubble on the window frame off of the avatar button. 382 // Shows the avatar bubble on the window frame off of the avatar button.
380 virtual void ShowAvatarBubbleFromAvatarButton() = 0; 383 virtual void ShowAvatarBubbleFromAvatarButton() = 0;
381 384
382 // Show bubble for password generation positioned relative to |rect|. |form| 385 // Show bubble for password generation positioned relative to |rect|. The
383 // is the form that contains the password field that the bubble will be 386 // subclasses implementing this interface do not own the |password_generator|
384 // associated with. A stub implementation is provided since this feature is 387 // object which is passed to generate the password. |form| is the form that
385 // currently not available on mac. 388 // contains the password field that the bubble will be associated with. A
389 // stub implementation is provided since this feature is currently not
390 // available on mac.
386 virtual void ShowPasswordGenerationBubble( 391 virtual void ShowPasswordGenerationBubble(
387 const gfx::Rect& rect, 392 const gfx::Rect& rect,
393 autofill::PasswordGenerator* password_generator,
388 const webkit::forms::PasswordForm& form) {} 394 const webkit::forms::PasswordForm& form) {}
389 395
390 protected: 396 protected:
391 friend void browser::CloseAllBrowsers(); 397 friend void browser::CloseAllBrowsers();
392 friend class BrowserView; 398 friend class BrowserView;
393 virtual void DestroyBrowser() = 0; 399 virtual void DestroyBrowser() = 0;
394 }; 400 };
395 401
396 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS) 402 #if defined(OS_WIN) || defined(TOOLKIT_VIEWS)
397 class BookmarkBarView; 403 class BookmarkBarView;
(...skipping 20 matching lines...) Expand all
418 424
419 // Returns the ToolbarView. 425 // Returns the ToolbarView.
420 virtual ToolbarView* GetToolbarView() const = 0; 426 virtual ToolbarView* GetToolbarView() const = 0;
421 #endif 427 #endif
422 428
423 protected: 429 protected:
424 virtual ~BrowserWindowTesting() {} 430 virtual ~BrowserWindowTesting() {}
425 }; 431 };
426 432
427 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 433 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/autofill/password_generator_unittest.cc ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698