chrome/common/autofill_messages.h - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/autofill_messages.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some changes based on the code review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator.cc ('K') | « chrome/browser/ui/views/password_generation_bubble_view.cc ('k') | chrome/renderer/autofill/password_generation_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/autofill_messages.h

diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h

index fa171767b4bbbfd5e1ea466af512cd5bfef67740..b3e05e8a481ede89cf81587cc882c6ee7063af1e 100644

--- a/chrome/common/autofill_messages.h

+++ b/chrome/common/autofill_messages.h

@@ -200,8 +200,9 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_HideAutofillPopup)

// Instructs the browser to show the password generation bubble at the

// specified location. This location should be specified in the renderers

// coordinate system.

-IPC_MESSAGE_ROUTED1(AutofillHostMsg_ShowPasswordGenerationPopup,

- gfx::Rect /* source location */)

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_ShowPasswordGenerationPopup,

+ gfx::Rect /* source location */,

+ int /* max length of the password */)

// Instruct the browser that a password mapping has been found for a field.

IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,