chrome/browser/ui/views/password_generation_bubble_view.cc - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/password_generation_bubble_view.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some changes based on the code review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator.cc ('K') | « chrome/browser/ui/views/password_generation_bubble_view.h ('k') | chrome/common/autofill_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/password_generation_bubble_view.cc

diff --git a/chrome/browser/ui/views/password_generation_bubble_view.cc b/chrome/browser/ui/views/password_generation_bubble_view.cc

index d97464a2c11f423f08cc918bb37542cd6c76d462..f647e19d0461dd8338d31b3185431257e61ee543 100644

--- a/chrome/browser/ui/views/password_generation_bubble_view.cc

+++ b/chrome/browser/ui/views/password_generation_bubble_view.cc

@@ -20,12 +20,14 @@ using views::GridLayout;

PasswordGenerationBubbleView::PasswordGenerationBubbleView(

const gfx::Rect& anchor_rect,

views::View* anchor_view,

- content::RenderViewHost* render_view_host)

+ content::RenderViewHost* render_view_host,

+ const autofill::PasswordGenerator& password_generator)

: BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),

accept_button_(NULL),

text_field_(NULL),

anchor_rect_(anchor_rect),

- render_view_host_(render_view_host) {}

+ render_view_host_(render_view_host),

+ password_generator_(password_generator) {}

PasswordGenerationBubbleView::~PasswordGenerationBubbleView() {}

@@ -36,7 +38,8 @@ void PasswordGenerationBubbleView::Init() {

ASCIIToUTF16("Try It"));

text_field_ = new views::Textfield();

- text_field_->SetText(ASCIIToUTF16(password_generator_.Generate()));

+ text_field_->SetText(

+ ASCIIToUTF16(password_generator_.Generate()));

views::Label* title_label = new views::Label(

ASCIIToUTF16("Password Suggestion"));