chrome/browser/ui/gtk/password_generation_bubble_gtk.cc - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some changes based on the code review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator.cc ('K') | « chrome/browser/ui/gtk/password_generation_bubble_gtk.h ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

index 2215496cb039786b4347b5bd1a70c8f31011ec8b..b0f2936eab491088e11048353e33ebd922dfc14f 100644

--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/ui/gtk/password_generation_bubble_gtk.h"

#include "base/utf_string_conversions.h"

+#include "chrome/browser/autofill/password_generator.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/gtk/bubble/bubble_gtk.h"

@@ -26,8 +27,11 @@ PasswordGenerationBubbleGtk::PasswordGenerationBubbleGtk(

const gfx::Rect& anchor_rect,

GtkWidget* anchor_widget,

Profile* profile,

- content::RenderViewHost* render_view_host)

- : profile_(profile), render_view_host_(render_view_host) {

+ content::RenderViewHost* render_view_host,

+ const autofill::PasswordGenerator& password_generator)

+ : profile_(profile),

+ render_view_host_(render_view_host),

+ password_generator_(password_generator) {

// TODO(gcasto): Localize text after we have finalized the UI.

// crbug.com/118062

GtkWidget* content = gtk_vbox_new(FALSE, 5);