chrome/browser/ui/views/frame/browser_view.h - Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 10458018: This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some changes based on the code review. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/password_generator.cc ('K') | « chrome/browser/ui/gtk/password_generation_bubble_gtk.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.h

diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h

index 27c974ad0604f91095693517aa2a20b5db6de844..49816f2540e7ac0f01cf1bfabdfb999cbf17e9fd 100644

--- a/chrome/browser/ui/views/frame/browser_view.h

+++ b/chrome/browser/ui/views/frame/browser_view.h

@@ -58,6 +58,10 @@ class JumpList;

class BrowserLauncherItemController;

#endif

+namespace autofill {

+class PasswordGenerator;

namespace extensions {

class Extension;

}

@@ -318,7 +322,9 @@ class BrowserView : public BrowserWindow,

virtual void ShowAvatarBubble(content::WebContents* web_contents,

const gfx::Rect& rect) OVERRIDE;

virtual void ShowAvatarBubbleFromAvatarButton() OVERRIDE;

- virtual void ShowPasswordGenerationBubble(const gfx::Rect& rect) OVERRIDE;

+ virtual void ShowPasswordGenerationBubble(

+ const gfx::Rect& rect,

+ const autofill::PasswordGenerator& password_generator) OVERRIDE;

// Overridden from BrowserWindowTesting:

virtual BookmarkBarView* GetBookmarkBarView() const OVERRIDE;