Issue 10458006: mac ninja/make: Do topological sort only once instead of at each access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10458006: mac ninja/make: Do topological sort only once instead of at each access. (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

mac ninja/make: Do topological sort only once instead of at each access. Speeds up ninja gyp time on mac from 34s to 31.8s. BUG=chromium:82230 TEST=none r1399

Patch Set 1 #

Total comments: 2

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -30 lines)			Patch
M	pylib/gyp/generator/make.py	View	6 chunks	+13 lines, -12 lines	0 comments	Download
M	pylib/gyp/generator/ninja.py	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	pylib/gyp/xcode_emulation.py	View	3 chunks	+15 lines, -8 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

just 2s, but easy 2s. Makes the runsnakerun output a bit less distracting.

8 years, 6 months ago (2012-05-28 20:47:20 UTC) #1

scottmg

lgtm https://chromiumcodereview.appspot.com/10458006/diff/1/pylib/gyp/xcode_emulation.py File pylib/gyp/xcode_emulation.py (right): https://chromiumcodereview.appspot.com/10458006/diff/1/pylib/gyp/xcode_emulation.py#newcode1017 pylib/gyp/xcode_emulation.py:1017: except gyp.common.CycleError, e: did this just not work ...

8 years, 6 months ago (2012-05-28 20:53:29 UTC) #2

Nico

8 years, 6 months ago (2012-05-28 20:57:17 UTC) #3

https://chromiumcodereview.appspot.com/10458006/diff/1/pylib/gyp/xcode_emulat...
File pylib/gyp/xcode_emulation.py (right):

https://chromiumcodereview.appspot.com/10458006/diff/1/pylib/gyp/xcode_emulat...
pylib/gyp/xcode_emulation.py:1017: except gyp.common.CycleError, e:
On 2012/05/28 20:53:29, scottmg wrote:
> did this just not work before?

Apparently.

Maybe the function had no callers in this file and in other modules CycleError
was already imported *handwave* No idea really, but python said "Don't know
CycleError" and I complied.

Expand Messages | Collapse Messages