Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2549)

Unified Diff: dart/tools/testing/dart/test_progress.dart

Issue 10456026: Create a unique name for each failure step. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_progress.dart
diff --git a/dart/tools/testing/dart/test_progress.dart b/dart/tools/testing/dart/test_progress.dart
index 5818d34f0b4be0ab16bda69dec728f9fb21663e9..ce15113b86a48f560e842dbb380f9f3e45237af0 100644
--- a/dart/tools/testing/dart/test_progress.dart
+++ b/dart/tools/testing/dart/test_progress.dart
@@ -360,8 +360,15 @@ class BuildbotProgressIndicator extends ProgressIndicator {
void _printFailureSummary() {
if (!_failureSummary.isEmpty()) {
+ // We need to create a unique name for each step, otherwise, the
+ // build bot will show the same failure when several steps
+ // fail. We don't know the name of the current step as it is
+ // printed by the program invoking this.
+ // TODO(ahe): Pass in the step name as an option, and let
+ // test.py take care of printing the steps.
+ var name = 'failures ($_startTime)';
print('@@@STEP_FAILURE@@@');
- print('@@@BUILD_STEP failures@@@');
+ print('@@@BUILD_STEP $name@@@');
}
super._printFailureSummary();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698