Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: dart/tools/testing/dart/test_progress.dart

Issue 10456026: Create a unique name for each failure step. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_progress"); 5 #library("test_progress");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("dart:builtin"); 8 #import("dart:builtin");
9 #import("test_runner.dart"); 9 #import("test_runner.dart");
10 #import("test_suite.dart"); 10 #import("test_suite.dart");
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 status = 'fail'; 353 status = 'fail';
354 } 354 }
355 var percent = ((_completedTests() / _foundTests) * 100).toInt().toString(); 355 var percent = ((_completedTests() / _foundTests) * 100).toInt().toString();
356 print('Done ${test.configurationString} ${test.displayName}: $status'); 356 print('Done ${test.configurationString} ${test.displayName}: $status');
357 print('@@@STEP_CLEAR@@@'); 357 print('@@@STEP_CLEAR@@@');
358 print('@@@STEP_TEXT@ $percent% +$_passedTests -$_failedTests @@@'); 358 print('@@@STEP_TEXT@ $percent% +$_passedTests -$_failedTests @@@');
359 } 359 }
360 360
361 void _printFailureSummary() { 361 void _printFailureSummary() {
362 if (!_failureSummary.isEmpty()) { 362 if (!_failureSummary.isEmpty()) {
363 // We need to create a unique name for each step, otherwise, the
364 // build bot will show the same failure when several steps
365 // fail. We don't know the name of the current step as it is
366 // printed by the program invoking this.
367 // TODO(ahe): Pass in the step name as an option, and let
368 // test.py take care of printing the steps.
369 var name = 'failures ($_startTime)';
363 print('@@@STEP_FAILURE@@@'); 370 print('@@@STEP_FAILURE@@@');
364 print('@@@BUILD_STEP failures@@@'); 371 print('@@@BUILD_STEP $name@@@');
365 } 372 }
366 super._printFailureSummary(); 373 super._printFailureSummary();
367 } 374 }
368 } 375 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698