Change three more instructions on x64 to use location-based codegen templates.

Change three more instructions on x64 to use location-based codegen templates.

This is a straight-forward port of the existing templates. For the future we
may consider refactoring those instructions to be like normal calls with arguments
 pushed on the stack explictly in the IL.
Committed: https://code.google.com/p/dart/source/detail?r=8050

[Vyacheslav Egorov (Google), 2012-05-29 10:29:09]

LGTM

http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.cc
File vm/intermediate_language_x64.cc (right):

http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.c...
vm/intermediate_language_x64.cc:384: Register receiver = locs()->in(0).reg();
please add TODO to mark these instructions as doing manual preservation of the
value.

we need to eliminate manual spilling later.

[Florian Schneider, 2012-05-29 10:55:33]

Done.

On 2012/05/29 10:29:09, Vyacheslav Egorov (Google) wrote:
> LGTM
> 
> http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.cc
> File vm/intermediate_language_x64.cc (right):
> 
>
http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.c...
> vm/intermediate_language_x64.cc:384: Register receiver = locs()->in(0).reg();
> please add TODO to mark these instructions as doing manual preservation of the
> value.
> 
> we need to eliminate manual spilling later.

[srdjan, 2012-05-29 15:04:03]

http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.cc
File vm/intermediate_language_x64.cc (right):

http://codereview.chromium.org/10456012/diff/1/vm/intermediate_language_x64.c...
vm/intermediate_language_x64.cc:387: Register result = locs()->out().reg();
We can simplify the code by using (if needed) the expression temporary across
the instance call. I will look into it today.