Issue 10455017: Add new function signatures needed for buffer allocation in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10455017: Add new function signatures needed for buffer allocation in Chrome. (Closed)

Created:
8 years, 7 months ago by rbultje1

Modified:
8 years, 6 months ago

Reviewers:
DaleCurtis, Ami GONE FROM CHROMIUM, scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/third_party/ffmpeg.git@master

Visibility:
Public.

More Reviews

Description

Add new function signatures needed for buffer allocation in Chrome. BUG= TEST=

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chromium/avcodec-54.sigs	View		1 chunk	+3 lines, -0 lines	1 comment	Download
	M	chromium/avutil-51.sigs	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ami GONE FROM CHROMIUM

8 years, 6 months ago (2012-05-28 18:30:01 UTC) #2

LGTM % not needing two of the methods.

https://chromiumcodereview.appspot.com/10455017/diff/1/chromium/avcodec-54.sigs
File chromium/avcodec-54.sigs (right):

https://chromiumcodereview.appspot.com/10455017/diff/1/chromium/avcodec-54.si...
chromium/avcodec-54.sigs:25: int avcodec_default_get_buffer(AVCodecContext *s,
AVFrame *pic);
See my comments on the other CL; hopefully you can drop this and the next line
from this CL.

Expand Messages | Collapse Messages