Block ptrace (and ptrace-like) syscalls from the renderer and worker processs.

Block ptrace (and ptrace-like) syscalls from the renderer and worker processs.

BUG=125225
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140080

[Chris Evans, 2012-06-01 06:06:31]

Defense in depth, we like.
Also, a quick think to make sure I didn't forget any other syscalls with the
same power?

[Chris Evans, 2012-06-01 06:16:12]

John, I'll probably need your OWNERS lgtm on this one, due to the 1-liners
outside of sandbox_init_linux.

[jochen (gone - plz use gerrit), 2012-06-01 11:23:10]

unofficial content lg

[jln (very slow on Chromium), 2012-06-01 18:34:37]

https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
File content/common/sandbox_init_linux.cc (right):

https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
content/common/sandbox_init_linux.cc:356:
EmitDenySyscall(__NR_process_vm_writev, program);
Not a huge deal, but maybe add move_pages and migrate_pages as well ?

https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
content/common/sandbox_init_linux.cc:409: } else {
This whole section (up to line 418) is becoming difficult to read.

Maybe have a switch statement to make it clear in one place what programs are
generated for each case?

[Chris Evans, 2012-06-01 18:55:12]

On 2012/06/01 18:34:37, Julien Tinnes wrote:
>
https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
> File content/common/sandbox_init_linux.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
> content/common/sandbox_init_linux.cc:356:
> EmitDenySyscall(__NR_process_vm_writev, program);
> Not a huge deal, but maybe add move_pages and migrate_pages as well ?

Done.

> 
>
https://chromiumcodereview.appspot.com/10454110/diff/1/content/common/sandbox...
> content/common/sandbox_init_linux.cc:409: } else {
> This whole section (up to line 418) is becoming difficult to read.
> 
> Maybe have a switch statement to make it clear in one place what programs are
> generated for each case?

Can't use a switch here but I simplified things a little.

[jln (very slow on Chromium), 2012-06-01 19:00:15]

lgtm

[jam, 2012-06-01 19:09:57]

lgtm