Dispatch a new event chrome.contextMenus.onClicked.

Dispatch a new event chrome.contextMenus.onClicked.

Disallow onclick create parameter for event pages.

Fix onClickData, which had incorrect types and missing fields.

BUG=123366
TEST=Register a chrome.contextMenus.onClicked handler in an event page (adding the menu items upon chrome.runtime.onInstalled). Check that it fires.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140112

[Yoyo Zhou, 2012-06-01 01:21:38]

FYI, I'm writing a browsertest to check that this works for event pages, but
it's going to involve some refactoring of the lazy background page browsertest
stuff, so I'll put up a separate CL for that.

[Matt Perry, 2012-06-01 01:57:15]

lgtm

http://codereview.chromium.org/10454106/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/context_menu/context_menu_api.cc (right):

http://codereview.chromium.org/10454106/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/context_menu/context_menu_api.cc:32: "pass an
onclick parameter to chrome.contextMenus.create";
nit: add "Use the chrome.contextMenus.onClicked event instead"

[Yoyo Zhou, 2012-06-01 18:17:51]

Turns out there were several more missing parameters from onClickData in the
json schema. If you were afraid we might not have checked the parameters in that
callback... your worst fears have been *validated*.

I also put the context menu event names into extension_event_names.

http://codereview.chromium.org/10454106/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/context_menu/context_menu_api.cc (right):

http://codereview.chromium.org/10454106/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/context_menu/context_menu_api.cc:32: "pass an
onclick parameter to chrome.contextMenus.create";
On 2012/06/01 01:57:15, Matt Perry wrote:
> nit: add "Use the chrome.contextMenus.onClicked event instead"

Done.

[Matt Perry, 2012-06-01 18:48:16]

lgtm

[Aaron Boodman, 2012-06-01 19:08:11]

http://codereview.chromium.org/10454106/diff/12004/chrome/common/extensions/a...
File chrome/common/extensions/api/context_menus.json (left):

http://codereview.chromium.org/10454106/diff/12004/chrome/common/extensions/a...
chrome/common/extensions/api/context_menus.json:60: "type": "string",
lawls

[Aaron Boodman, 2012-06-01 19:08:24]

(lgtm)