Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6873)

Unified Diff: chrome/browser/extensions/extension_menu_manager.cc

Issue 10454106: Dispatch a new event chrome.contextMenus.onClicked. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: names Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_menu_manager.cc
diff --git a/chrome/browser/extensions/extension_menu_manager.cc b/chrome/browser/extensions/extension_menu_manager.cc
index 99d6fc4de806eb91c3d1052b0d60b00d9e2f6cc2..d0fb4375c378fbae2e0cfa485fc782ef6f20e424 100644
--- a/chrome/browser/extensions/extension_menu_manager.cc
+++ b/chrome/browser/extensions/extension_menu_manager.cc
@@ -12,6 +12,7 @@
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
+#include "chrome/browser/extensions/extension_event_names.h"
#include "chrome/browser/extensions/extension_event_router.h"
#include "chrome/browser/extensions/extension_prefs.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -603,11 +604,14 @@ void ExtensionMenuManager::ExecuteCommand(
std::string json_args;
base::JSONWriter::Write(&args, &json_args);
- std::string event_name = "contextMenus";
event_router->DispatchEventToExtension(
- item->extension_id(), event_name, json_args, profile, GURL(),
+ item->extension_id(), extension_event_names::kOnContextMenus,
+ json_args, profile, GURL(),
+ ExtensionEventRouter::USER_GESTURE_ENABLED);
+ event_router->DispatchEventToExtension(
+ item->extension_id(), extension_event_names::kOnContextMenuClicked,
+ json_args, profile, GURL(),
ExtensionEventRouter::USER_GESTURE_ENABLED);
- // TODO(yoz): dispatch another event onClicked.
}
void ExtensionMenuManager::SanitizeRadioList(

Powered by Google App Engine
This is Rietveld 408576698