Issue 10454008: Merge 117102 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10454008: Merge 117102 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8 (Closed)

Created:
8 years, 7 months ago by karen

Modified:
8 years, 7 months ago

Reviewers:
tommyw

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/

Visibility:
Public.

More Reviews

Description

Merge 117102 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8 https://bugs.webkit.org/show_bug.cgi?id=86459 Reviewed by Adam Barth. Source/WebCore: LocalMediaStream inherits from MediaStream, but only MediaStream have the EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue. Test: fast/mediastream/LocalMediaStream-onended.html * Modules/mediastream/LocalMediaStream.idl: LayoutTests: * fast/mediastream/LocalMediaStream-onended-expected.txt: Added. * fast/mediastream/LocalMediaStream-onended.html: Added. TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118363

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-1 lines, --2 lines)			Patch
A +	LayoutTests/fast/mediastream/LocalMediaStream-onended.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/Modules/mediastream/LocalMediaStream.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages