Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 10454008: Merge 117102 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8 (Closed)

Created:
8 years, 7 months ago by karen
Modified:
8 years, 7 months ago
Reviewers:
tommyw
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 117102 - MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8 https://bugs.webkit.org/show_bug.cgi?id=86459 Reviewed by Adam Barth. Source/WebCore: LocalMediaStream inherits from MediaStream, but only MediaStream have the EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue. Test: fast/mediastream/LocalMediaStream-onended.html * Modules/mediastream/LocalMediaStream.idl: LayoutTests: * fast/mediastream/LocalMediaStream-onended-expected.txt: Added. * fast/mediastream/LocalMediaStream-onended.html: Added. TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --2 lines) Patch
A + LayoutTests/fast/mediastream/LocalMediaStream-onended.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/mediastream/LocalMediaStream-onended-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/Modules/mediastream/LocalMediaStream.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 7 months ago (2012-05-24 14:02:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698