Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 10453112: Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to re… (Closed)

Created:
8 years, 6 months ago by yosin_UTC9
Modified:
8 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection https://bugs.webkit.org/show_bug.cgi?id=87614 Reviewed by Kent Tamura. Source/WebCore: This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl methods which was implemented in HTMLFormControlElement at r109729 and updates CSS pseudo class checker to check "optgroup" element. Tests: fast/forms/select/optgroup-clicking.html fast/forms/select/optgroup-disabled.html fast/forms/select/optgroup-rendering.html * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker. We checked tag name "optgroup" in addition isFormControlElement. * css/StyleResolver.cpp: (WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled. * html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::disabled): Added. * html/HTMLOptGroupElement.h: (HTMLOptGroupElement): Added isEnabledFormControl. LayoutTests: Note: An image for optgroup-rendering.html will be change due by BUG-87719. Color of option elements should be blue (:enabled pseudo class) instead of green. * fast/forms/select/optgroup-clicking-expected.txt: Added. * fast/forms/select/optgroup-clicking.html: Added. * fast/forms/select/optgroup-disabled-expected.txt: Added. * fast/forms/select/optgroup-disabled.html: Added. * fast/forms/select/optgroup-rendering.html: Added. * platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html. * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added. * platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, --3 lines) Patch
A + LayoutTests/fast/forms/select/optgroup-clicking.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/optgroup-clicking-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/optgroup-disabled.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/optgroup-disabled-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/optgroup-rendering.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/css/SelectorChecker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/css/StyleResolver.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/html/HTMLOptGroupElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/html/HTMLOptGroupElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
8 years, 6 months ago (2012-06-01 02:01:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698