Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: Source/WebCore/css/StyleResolver.cpp

Issue 10453112: Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to re… (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/css/SelectorChecker.cpp ('k') | Source/WebCore/html/HTMLOptGroupElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 1355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1366 HTMLProgressElement* thisProgressElement = static_cast<HTMLProgressEleme nt*>(element); 1366 HTMLProgressElement* thisProgressElement = static_cast<HTMLProgressEleme nt*>(element);
1367 HTMLProgressElement* otherProgressElement = static_cast<HTMLProgressElem ent*>(m_element); 1367 HTMLProgressElement* otherProgressElement = static_cast<HTMLProgressElem ent*>(m_element);
1368 if (thisProgressElement->isDeterminate() != otherProgressElement->isDete rminate()) 1368 if (thisProgressElement->isDeterminate() != otherProgressElement->isDete rminate())
1369 return false; 1369 return false;
1370 } 1370 }
1371 #endif 1371 #endif
1372 1372
1373 if (element->hasTagName(optionTag)) 1373 if (element->hasTagName(optionTag))
1374 return false; 1374 return false;
1375 1375
1376 if (element->hasTagName(optgroupTag) && m_element->disabled() != element->di sabled())
1377 return false;
1378
1376 bool isControl = element->isFormControlElement(); 1379 bool isControl = element->isFormControlElement();
1377 1380
1378 if (isControl != m_element->isFormControlElement()) 1381 if (isControl != m_element->isFormControlElement())
1379 return false; 1382 return false;
1380 1383
1381 if (isControl && !canShareStyleWithControl(element)) 1384 if (isControl && !canShareStyleWithControl(element))
1382 return false; 1385 return false;
1383 1386
1384 if (style->transitions() || style->animations()) 1387 if (style->transitions() || style->animations())
1385 return false; 1388 return false;
(...skipping 4457 matching lines...) Expand 10 before | Expand all | Expand 10 after
5843 } 5846 }
5844 default: 5847 default:
5845 ASSERT_NOT_REACHED(); 5848 ASSERT_NOT_REACHED();
5846 } 5849 }
5847 } 5850 }
5848 5851
5849 m_pendingImageProperties.clear(); 5852 m_pendingImageProperties.clear();
5850 } 5853 }
5851 5854
5852 } // namespace WebCore 5855 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/css/SelectorChecker.cpp ('k') | Source/WebCore/html/HTMLOptGroupElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698