Add support for response header manipulation in Declarative WebRequest API

Add support for response header manipulation in Declarative WebRequest API


BUG=112155
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139509

[battre, 2012-05-29 20:13:18]

Hi Matt,

could you review this please?

Thank you,
Dominic

[Matt Perry, 2012-05-29 21:24:27]

lgtm

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h
(right):

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/browser/exte...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h:48:
OptionalRequestData() : original_response_headers(0) {}
use NULL rather than 0

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/common/exten...
File chrome/common/extensions/api/declarative_web_request.json (right):

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/common/exten...
chrome/common/extensions/api/declarative_web_request.json:104: "description":
"Adds the response header to the response of this web request. As multiple
response headers may share the same name, you need to first remove and then add
a new response header in order to replace a one.",
"a one" => "one"

[battre, 2012-05-30 07:35:06]

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/browser/exte...
File chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h
(right):

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/browser/exte...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.h:48:
OptionalRequestData() : original_response_headers(0) {}
On 2012/05/29 21:24:27, Matt Perry wrote:
> use NULL rather than 0

Done.

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/common/exten...
File chrome/common/extensions/api/declarative_web_request.json (right):

https://chromiumcodereview.appspot.com/10451071/diff/5001/chrome/common/exten...
chrome/common/extensions/api/declarative_web_request.json:104: "description":
"Adds the response header to the response of this web request. As multiple
response headers may share the same name, you need to first remove and then add
a new response header in order to replace a one.",
On 2012/05/29 21:24:27, Matt Perry wrote:
> "a one" => "one"

Done.

[commit-bot: I haz the power, 2012-05-30 07:35:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10451071/4002

[commit-bot: I haz the power, 2012-05-30 07:35:44]

Failed to apply patch for
chrome/common/extensions/docs/declarativeWebRequest.html:
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/declarativeWebRequest.html
Hunk #4 FAILED at 831.
1 out of 5 hunks FAILED -- saving rejects to file
chrome/common/extensions/docs/declarativeWebRequest.html.rej

[commit-bot: I haz the power, 2012-05-30 07:47:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10451071/19

[commit-bot: I haz the power, 2012-05-30 09:11:55]

Change committed as 139509