Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: sync/notifier/chrome_invalidation_client_unittest.cc

Issue 10451060: sync: migrate invalidation state from syncable::Directory to InvalidationStorage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: include order Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/chrome_invalidation_client.cc ('k') | sync/notifier/invalidation_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/chrome_invalidation_client_unittest.cc
diff --git a/sync/notifier/chrome_invalidation_client_unittest.cc b/sync/notifier/chrome_invalidation_client_unittest.cc
index 09d100f35bace708c9b9855307940b7bde3e8c59..4de8ce0493451bf2db524281a399ad7b674e0b76 100644
--- a/sync/notifier/chrome_invalidation_client_unittest.cc
+++ b/sync/notifier/chrome_invalidation_client_unittest.cc
@@ -10,7 +10,7 @@
#include "google/cacheinvalidation/v2/types.pb.h"
#include "jingle/notifier/listener/fake_push_client.h"
#include "sync/notifier/chrome_invalidation_client.h"
-#include "sync/notifier/state_writer.h"
+#include "sync/notifier/mock_invalidation_state_tracker.h"
#include "sync/syncable/model_type.h"
#include "sync/syncable/model_type_payload_map.h"
#include "sync/util/weak_handle.h"
@@ -28,6 +28,7 @@ namespace {
const char kClientId[] = "client_id";
const char kClientInfo[] = "client_info";
const char kState[] = "state";
+const char kNewState[] = "new_state";
class MockInvalidationClient : public invalidation::InvalidationClient {
public:
@@ -46,21 +47,6 @@ class MockListener : public ChromeInvalidationClient::Listener {
MOCK_METHOD1(OnSessionStatusChanged, void(bool));
};
-class MockInvalidationStateTracker
- : public InvalidationStateTracker,
- public base::SupportsWeakPtr<MockInvalidationStateTracker> {
- public:
- MOCK_CONST_METHOD0(GetAllMaxVersions, InvalidationVersionMap());
- MOCK_METHOD2(SetMaxVersion, void(syncable::ModelType, int64));
- MOCK_CONST_METHOD0(GetInvalidationState, std::string());
- MOCK_METHOD1(SetInvalidationState, void(const std::string&));
-};
-
-class MockStateWriter : public StateWriter {
- public:
- MOCK_METHOD1(WriteState, void(const std::string&));
-};
-
} // namespace
class ChromeInvalidationClientTest : public testing::Test {
@@ -75,7 +61,7 @@ class ChromeInvalidationClientTest : public testing::Test {
InvalidationVersionMap(),
browser_sync::MakeWeakHandle(
mock_invalidation_state_tracker_.AsWeakPtr()),
- &mock_listener_, &mock_state_writer_);
+ &mock_listener_);
}
virtual void TearDown() {
@@ -129,7 +115,6 @@ class ChromeInvalidationClientTest : public testing::Test {
StrictMock<MockListener> mock_listener_;
StrictMock<MockInvalidationStateTracker>
mock_invalidation_state_tracker_;
- StrictMock<MockStateWriter> mock_state_writer_;
StrictMock<MockInvalidationClient> mock_invalidation_client_;
ChromeInvalidationClient client_;
};
@@ -174,6 +159,12 @@ TEST_F(ChromeInvalidationClientTest, InvalidateWithPayload) {
FireInvalidate("PREFERENCE", 1, "payload");
}
+TEST_F(ChromeInvalidationClientTest, WriteState) {
+ EXPECT_CALL(mock_invalidation_state_tracker_,
+ SetInvalidationState(kNewState));
+ client_.WriteState(kNewState);
+}
+
TEST_F(ChromeInvalidationClientTest, InvalidateVersion) {
using ::testing::Mock;
« no previous file with comments | « sync/notifier/chrome_invalidation_client.cc ('k') | sync/notifier/invalidation_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698