sync: migrate invalidation state from syncable::Directory to InvalidationStorage

sync/notifier/chrome_invalidation_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/message_loop.h"
 #include "google/cacheinvalidation/include/invalidation-client.h"
 #include "google/cacheinvalidation/include/types.h"
 #include "google/cacheinvalidation/v2/types.pb.h"
 #include "jingle/notifier/listener/fake_push_client.h"
 #include "sync/notifier/chrome_invalidation_client.h"
-#include "sync/notifier/state_writer.h"
+#include "sync/notifier/mock_invalidation_state_tracker.h"
 #include "sync/syncable/model_type.h"
 #include "sync/syncable/model_type_payload_map.h"
 #include "sync/util/weak_handle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace sync_notifier {
 
 using ::testing::_;
 using ::testing::Return;
 using ::testing::StrictMock;
 
 namespace {
 
 const char kClientId[] = "client_id";
 const char kClientInfo[] = "client_info";
 const char kState[] = "state";
+const char kNewState[] = "new_state";
 
 class MockInvalidationClient : public invalidation::InvalidationClient {
  public:
   MOCK_METHOD0(Start, void());
   MOCK_METHOD0(Stop, void());
   MOCK_METHOD1(Register, void(const invalidation::ObjectId&));
   MOCK_METHOD1(Register, void(const std::vector<invalidation::ObjectId>&));
   MOCK_METHOD1(Unregister, void(const invalidation::ObjectId&));
   MOCK_METHOD1(Unregister, void(const std::vector<invalidation::ObjectId>&));
   MOCK_METHOD1(Acknowledge, void(const invalidation::AckHandle&));
 };
 
 class MockListener : public ChromeInvalidationClient::Listener {
  public:
   MOCK_METHOD1(OnInvalidate, void(const syncable::ModelTypePayloadMap&));
   MOCK_METHOD1(OnSessionStatusChanged, void(bool));
 };
 
-class MockInvalidationStateTracker
-    : public InvalidationStateTracker,
-      public base::SupportsWeakPtr<MockInvalidationStateTracker> {
- public:
-  MOCK_CONST_METHOD0(GetAllMaxVersions, InvalidationVersionMap());
-  MOCK_METHOD2(SetMaxVersion, void(syncable::ModelType, int64));
-  MOCK_CONST_METHOD0(GetInvalidationState, std::string());
-  MOCK_METHOD1(SetInvalidationState, void(const std::string&));
-};
-
-class MockStateWriter : public StateWriter {
- public:
-  MOCK_METHOD1(WriteState, void(const std::string&));
-};
-
 }  // namespace
 
 class ChromeInvalidationClientTest : public testing::Test {
  protected:
   ChromeInvalidationClientTest()
       : client_(
           scoped_ptr<notifier::PushClient>(
               new notifier::FakePushClient())) {}
 
   virtual void SetUp() {
     client_.Start(kClientId, kClientInfo, kState,
                   InvalidationVersionMap(),
                   browser_sync::MakeWeakHandle(
                       mock_invalidation_state_tracker_.AsWeakPtr()),
-                  &mock_listener_, &mock_state_writer_);
+                  &mock_listener_);
   }
 
   virtual void TearDown() {
     // client_.Stop() stops the invalidation scheduler, which deletes any
     // pending tasks without running them.  Some tasks "run and delete" another
     // task, so they must be run in order to avoid leaking the inner task.
     // client_.Stop() does not schedule any tasks, so it's both necessary and
     // sufficient to drain the task queue before calling it.
     message_loop_.RunAllPending();
     client_.Stop();
@@ skipping 33 matching lines @@
   void FireInvalidateAll() {
     invalidation::AckHandle ack_handle("fakedata");
     EXPECT_CALL(mock_invalidation_client_, Acknowledge(ack_handle));
     client_.InvalidateAll(&mock_invalidation_client_, ack_handle);
   }
 
   MessageLoop message_loop_;
   StrictMock<MockListener> mock_listener_;
   StrictMock<MockInvalidationStateTracker>
       mock_invalidation_state_tracker_;
-  StrictMock<MockStateWriter> mock_state_writer_;
   StrictMock<MockInvalidationClient> mock_invalidation_client_;
   ChromeInvalidationClient client_;
 };
 
 namespace {
 
 syncable::ModelTypePayloadMap MakeMap(syncable::ModelType model_type,
                                       const std::string& payload) {
   syncable::ModelTypePayloadMap type_payloads;
   type_payloads[model_type] = payload;
@@ skipping 24 matching lines @@
 }
 
 TEST_F(ChromeInvalidationClientTest, InvalidateWithPayload) {
   EXPECT_CALL(mock_listener_,
               OnInvalidate(MakeMap(syncable::PREFERENCES, "payload")));
   EXPECT_CALL(mock_invalidation_state_tracker_,
               SetMaxVersion(syncable::PREFERENCES, 1));
   FireInvalidate("PREFERENCE", 1, "payload");
 }
 
+TEST_F(ChromeInvalidationClientTest, WriteState) {
+  EXPECT_CALL(mock_invalidation_state_tracker_,
+              SetInvalidationState(kNewState));
+  client_.WriteState(kNewState);
+}
+
 TEST_F(ChromeInvalidationClientTest, InvalidateVersion) {
   using ::testing::Mock;
 
   EXPECT_CALL(mock_listener_,
               OnInvalidate(MakeMap(syncable::APPS, "")));
   EXPECT_CALL(mock_invalidation_state_tracker_,
               SetMaxVersion(syncable::APPS, 1));
 
   // Should trigger.
   FireInvalidate("APP", 1, NULL);
@@ skipping 84 matching lines @@
   // Registered types should be preserved across Stop/Start.
   TearDown();
   SetUp();
   EXPECT_CALL(mock_listener_, OnInvalidate(MakeMapFromSet(types, "")));
   FireInvalidateAll();
 }
 
 // TODO(akalin): Flesh out unit tests.
 
 }  // namespace sync_notifier