Issue 10451037: ARM: Add literal pool blocking to position critical code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10451037: ARM: Add literal pool blocking to position critical code. (Closed)

Created:
8 years, 7 months ago by m.m.capewell

Modified:
8 years, 6 months ago

Reviewers:
Sven Panne, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Add literal pool blocking to position critical code. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=11784

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -33 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	5 chunks	+40 lines, -16 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+27 lines, -14 lines	0 comments	Download
M	test/cctest/test-disasm-arm.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

m.m.capewell

This patch fixes most of the bugs we've found so far that are due to ...

8 years, 7 months ago (2012-05-25 12:54:16 UTC) #1

m.m.capewell

Ping. Anybody have time to look at this? It should bring stability improvements. Thanks.

8 years, 6 months ago (2012-06-12 13:06:20 UTC) #2

Sven Panne

8 years, 6 months ago (2012-06-12 17:26:09 UTC) #4

LGTM, I'll land this CL. 2 remarks:

  * Finding the places where blocking is necessary is tricky, can we perhaps
find a mechanical way to detect these?

  * Our ToT is currently in a pitiful state, but it seems that this CL doesn't
make it any worse. ;-)

Expand Messages | Collapse Messages