runtime/vm/assembler_macros_ia32.cc - Issue 10450014: Request for comments on overall approach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_macros_ia32.cc

Issue 10450014: Request for comments on overall approach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix scavenger and freelist handling Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_macros_ia32.cc

diff --git a/runtime/vm/assembler_macros_ia32.cc b/runtime/vm/assembler_macros_ia32.cc

index b5477cb9d32bae8d07ff9950a24fb06fc7da58a7..038ddc5a38332f340ca6268d7bd9e477d3f6dcda 100644

--- a/runtime/vm/assembler_macros_ia32.cc

+++ b/runtime/vm/assembler_macros_ia32.cc

@@ -44,9 +44,7 @@ void AssemblerMacros::TryAllocate(Assembler* assembler,

__ movl(Address::Absolute(heap->TopAddress()), instance_reg);

ASSERT(instance_size >= kHeapObjectTag);

__ subl(instance_reg, Immediate(instance_size - kHeapObjectTag));

- __ StoreIntoObject(instance_reg,

- FieldAddress(instance_reg, Instance::class_offset()),

- class_reg);

uword tags = 0;

tags = RawObject::SizeTag::update(instance_size, tags);

ASSERT(cls.index() != kIllegalObjectKind);