Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: runtime/vm/assembler_macros_ia32.cc

Issue 10450014: Request for comments on overall approach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix scavenger and freelist handling Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler_macros.h" 8 #include "vm/assembler_macros.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 26 matching lines...) Expand all
37 __ movl(instance_reg, Address::Absolute(heap->TopAddress())); 37 __ movl(instance_reg, Address::Absolute(heap->TopAddress()));
38 __ addl(instance_reg, Immediate(instance_size)); 38 __ addl(instance_reg, Immediate(instance_size));
39 // instance_reg: potential next object start. 39 // instance_reg: potential next object start.
40 __ cmpl(instance_reg, Address::Absolute(heap->EndAddress())); 40 __ cmpl(instance_reg, Address::Absolute(heap->EndAddress()));
41 __ j(ABOVE_EQUAL, failure, Assembler::kNearJump); 41 __ j(ABOVE_EQUAL, failure, Assembler::kNearJump);
42 // Successfully allocated the object, now update top to point to 42 // Successfully allocated the object, now update top to point to
43 // next object start and store the class in the class field of object. 43 // next object start and store the class in the class field of object.
44 __ movl(Address::Absolute(heap->TopAddress()), instance_reg); 44 __ movl(Address::Absolute(heap->TopAddress()), instance_reg);
45 ASSERT(instance_size >= kHeapObjectTag); 45 ASSERT(instance_size >= kHeapObjectTag);
46 __ subl(instance_reg, Immediate(instance_size - kHeapObjectTag)); 46 __ subl(instance_reg, Immediate(instance_size - kHeapObjectTag));
47 __ StoreIntoObject(instance_reg, 47
48 FieldAddress(instance_reg, Instance::class_offset()),
49 class_reg);
50 uword tags = 0; 48 uword tags = 0;
51 tags = RawObject::SizeTag::update(instance_size, tags); 49 tags = RawObject::SizeTag::update(instance_size, tags);
52 ASSERT(cls.index() != kIllegalObjectKind); 50 ASSERT(cls.index() != kIllegalObjectKind);
53 tags = RawObject::ClassTag::update(cls.index(), tags); 51 tags = RawObject::ClassTag::update(cls.index(), tags);
54 __ movl(FieldAddress(instance_reg, Object::tags_offset()), Immediate(tags)); 52 __ movl(FieldAddress(instance_reg, Object::tags_offset()), Immediate(tags));
55 } else { 53 } else {
56 __ jmp(failure); 54 __ jmp(failure);
57 } 55 }
58 } 56 }
59 57
(...skipping 19 matching lines...) Expand all
79 void AssemblerMacros::EnterStubFrame(Assembler* assembler) { 77 void AssemblerMacros::EnterStubFrame(Assembler* assembler) {
80 __ EnterFrame(0); 78 __ EnterFrame(0);
81 __ pushl(Immediate(0)); // Push 0 in the saved PC area for stub frames. 79 __ pushl(Immediate(0)); // Push 0 in the saved PC area for stub frames.
82 } 80 }
83 81
84 #undef __ 82 #undef __
85 83
86 } // namespace dart 84 } // namespace dart
87 85
88 #endif // defined TARGET_ARCH_IA32 86 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698