Transfer user agent override info between browser and renderer

content/browser/web_contents/interstitial_page_impl.cc

Index: content/browser/web_contents/interstitial_page_impl.cc
diff --git a/content/browser/web_contents/interstitial_page_impl.cc b/content/browser/web_contents/interstitial_page_impl.cc
index c5432ee3aeb9baa56bf687e422697154d830ff38..21e9a65641b55533d08cfc6392c329e5bc1121b5 100644
--- a/content/browser/web_contents/interstitial_page_impl.cc
+++ b/content/browser/web_contents/interstitial_page_impl.cc
@@ -503,7 +503,8 @@ WebContentsView* InterstitialPageImpl::CreateWebContentsView() {
   render_view_host_->CreateRenderView(string16(),
                                       MSG_ROUTING_NONE,
                                       max_page_id,
-                                      -1);
+                                      -1,
+                                      web_contents()->GetUserAgentOverride());

[Charlie Reis, 2012/06/01 00:36:08]

Is it meaningful for an interstitial page's user agent to be overridden here? 
Conversely, are there any risks to setting it to something unexpected?  I wonder
if it's better to just pass an empty string.

[gone, 2012/06/01 01:04:06]

It not exactly setting the interstitial's user agent override: it's setting the
override for the RenderView that it uses.  We set it here in case the RenderView
is reused for other navigations after the interstitial is discarded, and those
navigations need the user agent overridden.  I'm not sure what the rules are for
keeping this RenderView around are, though.

[Charlie Reis, 2012/06/01 18:04:09]

Ah.  An interstitial's RenderView will never be used by anyone else, so it's
safe to pass an empty string.

[gone, 2012/06/14 00:46:39]

Will pass in an empty string.

   view->SetSize(web_contents_view->GetContainerSize());
   // Don't show the interstitial until we have navigated to it.
   view->Hide();