Transfer user agent override info between browser and renderer

content/browser/web_contents/interstitial_page_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/interstitial_page_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 485 matching lines @@
   RenderWidgetHostView* view =
       web_contents_view->CreateViewForWidget(render_view_host_);
   render_view_host_->SetView(view);
   render_view_host_->AllowBindings(content::BINDINGS_POLICY_DOM_AUTOMATION);
 
   int32 max_page_id = web_contents()->
       GetMaxPageIDForSiteInstance(render_view_host_->GetSiteInstance());
   render_view_host_->CreateRenderView(string16(),
                                       MSG_ROUTING_NONE,
                                       max_page_id,
-                                      -1);
+                                      -1,
+                                      web_contents()->GetUserAgentOverride());

[Charlie Reis, 2012/06/01 00:36:08]

Is it meaningful for an interstitial page's user agent to be overridden here? 
Conversely, are there any risks to setting it to something unexpected?  I wonder
if it's better to just pass an empty string.

[gone, 2012/06/01 01:04:06]

It not exactly setting the interstitial's user agent override: it's setting the
override for the RenderView that it uses.  We set it here in case the RenderView
is reused for other navigations after the interstitial is discarded, and those
navigations need the user agent overridden.  I'm not sure what the rules are for
keeping this RenderView around are, though.

[Charlie Reis, 2012/06/01 18:04:09]

Ah.  An interstitial's RenderView will never be used by anyone else, so it's
safe to pass an empty string.

[gone, 2012/06/14 00:46:39]

Will pass in an empty string.

   view->SetSize(web_contents_view->GetContainerSize());
   // Don't show the interstitial until we have navigated to it.
   view->Hide();
   return web_contents_view;
 }
 
 void InterstitialPageImpl::Proceed() {
   if (action_taken_ != NO_ACTION) {
     NOTREACHED();
     return;
@@ skipping 213 matching lines @@
   if (!web_contents->GetViewDelegate())
     return;
 
   web_contents->GetViewDelegate()->TakeFocus(reverse);
 }
 
 void InterstitialPageImpl::InterstitialPageRVHViewDelegate::OnFindReply(
     int request_id, int number_of_matches, const gfx::Rect& selection_rect,
     int active_match_ordinal, bool final_update) {
 }