Chromium Code Reviews Chromium Code Reviews
Issue
10450002:
Transfer user agent override info between browser and renderer (Closed)
DescriptionTransfer user agent info between browser and renderer
Upstreaming "Request desktop site" feature from Android. Previous CLs:
* http://codereview.chromium.org/9999010/
Stores the original request URL in NavigationEntry
* http://codereview.chromium.org/10170016/
Adds info about user agent overrides to WebContents and NavigationEntries
* https://bugs.webkit.org/show_bug.cgi?id=83959
Adds ability to override the user agent string per-WebFrameClient
The previous CLs added the framework to the browser and renderer to support
overriding the default user agent with a different string. This CL connects the
two sides, letting the browser pass information about the user agent override the
renderer should be using for a given navigation.
There's a slightly out of date doc at http://go/chrome_android_rds that's being
adjusted as CLs land.
Changes from previous CLs:
* The user agent override string is now stored in the RendererPreferences instead
of directly inside the RenderViewImpl and WebContentsImpl.
* Setting the user agent override for a WebContents forces a reload if a page is
currently being loaded to avoid giving different parts of a web page different
user agents.
Additions:
* The browser-side lets the renderer know about the user agent override string
through an IPC call that occurs when the user agent is set in WebContentsImpl
and when a RenderViewImpl is created.
* Instant + Prefetch classes have been adjusted to set carry over the override flags
from the WebContents they're being used for.
* A new function is added to the NavigationController to allow setting the override
flag for a particular NavigationEntry before it is loaded.
* The NavigationController is alerted to new navigations by the renderer with an IPC
call and saves the override state in the relevant NavigationEntry.
* DocumentState stores whether the user agent override was used for a given navigation,
and is set in RenderViewImpl::didCreateDataSource(). Both browser- and
renderer-initiated navigations go through here, with
browser-initiated navigations using a ViewMsg_Navigate_Params.
* WebFrameClient::userAgentOverride() is overridden by RenderViewImpl to return the
user agent for the current main frame. If the main frame is provisionally loading
something, we use the override for the provisional load instead.
Internal bugs=6272286,6213026
BUG=112923
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143279
Patch Set 1 #Patch Set 2 : Updating commit log #Patch Set 3 : Adding new loadEntry type to allow prerenderer to change user agent #Patch Set 4 : Diff shows what we do downstream #
Total comments: 39
Patch Set 5 : Addessing comments #Patch Set 6 : Added logic to instant loader to match prerenderer #
Total comments: 2
Patch Set 7 : Moved override state to DocumentState #
Total comments: 9
Patch Set 8 : Cleand up userAgentOverride #
Total comments: 6
Patch Set 9 : Addressing nits #Patch Set 10 : Adding TODO to combine the NavigationController URL loading interfaces #Patch Set 11 : Rebasing #Patch Set 12 : Default to not overriding in prerender config #Messages
Total messages: 26 (0 generated)
|
