Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 10449108: Silence Windows warning. (Closed)

Created:
8 years, 6 months ago by rossberg
Modified:
8 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/d8.cc View 1 chunk +3 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
8 years, 6 months ago (2012-06-01 11:54:35 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/10449108/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10449108/diff/1/src/d8.cc#newcode447 src/d8.cc:447: object->ToObject()->Get(String::New("byteLength"))->Uint32Value(); Hmm, this looks strange, it implicitly casts uint32 ...
8 years, 6 months ago (2012-06-01 12:00:10 UTC) #2
rossberg
https://chromiumcodereview.appspot.com/10449108/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10449108/diff/1/src/d8.cc#newcode447 src/d8.cc:447: object->ToObject()->Get(String::New("byteLength"))->Uint32Value(); On 2012/06/01 12:00:10, Michael Starzinger wrote: > Hmm, ...
8 years, 6 months ago (2012-06-01 12:06:20 UTC) #3
Michael Starzinger
8 years, 6 months ago (2012-06-01 12:09:47 UTC) #4
LGTM (but I have the suspicion that Windows might still spit out a warning
here).

Powered by Google App Engine
This is Rietveld 408576698