Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: src/d8.cc

Issue 10449108: Silence Windows warning. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index 297bf79d09d5101bfd255d1b10483999e3644114..431782a3043512567107745e5717a1b342f5f59e 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -443,8 +443,9 @@ Handle<Value> Shell::CreateExternalArray(const Arguments& args,
void Shell::ExternalArrayWeakCallback(Persistent<Value> object, void* data) {
HandleScope scope;
- Local<Value> length = object->ToObject()->Get(String::New("byteLength"));
- V8::AdjustAmountOfExternalAllocatedMemory(-length->Uint32Value());
+ int32_t length =
+ object->ToObject()->Get(String::New("byteLength"))->Uint32Value();
Michael Starzinger 2012/06/01 12:00:10 Hmm, this looks strange, it implicitly casts uint3
rossberg 2012/06/01 12:06:20 It's done in other places, too. It's correct becau
+ V8::AdjustAmountOfExternalAllocatedMemory(-length);
delete[] static_cast<uint8_t*>(data);
object.Dispose();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698