Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: content/public/plugin/content_plugin_client.h

Issue 10449063: Create default implementations of ContentRendererClient, ContentUtilityClient, and ContentPluginCli… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/plugin/content_plugin_client.h
===================================================================
--- content/public/plugin/content_plugin_client.h (revision 139356)
+++ content/public/plugin/content_plugin_client.h (working copy)
@@ -12,10 +12,10 @@
namespace content {
// Embedder API for participating in plugin logic.
-class ContentPluginClient {
+class CONTENT_EXPORT ContentPluginClient {
tfarina 2012/05/30 00:26:49 does this need a virtual destructor?
jam 2012/05/30 14:50:21 yep according to the style guide, i'll add one.
public:
// Notifies that a plugin process has started.
- virtual void PluginProcessStarted(const string16& plugin_name) = 0;
+ virtual void PluginProcessStarted(const string16& plugin_name) {}
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698