Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: content/public/plugin/content_plugin_client.h

Issue 10449063: Create default implementations of ContentRendererClient, ContentUtilityClient, and ContentPluginCli… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_ 5 #ifndef CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
6 #define CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_ 6 #define CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/string16.h" 9 #include "base/string16.h"
10 #include "content/public/common/content_client.h" 10 #include "content/public/common/content_client.h"
tfarina 2012/05/30 00:26:49 looks like this include can be removed and content
jam 2012/05/30 14:50:21 by convention, all content_foo_client.h files incl
11 11
12 namespace content { 12 namespace content {
13 13
14 // Embedder API for participating in plugin logic. 14 // Embedder API for participating in plugin logic.
15 class ContentPluginClient { 15 class CONTENT_EXPORT ContentPluginClient {
tfarina 2012/05/30 00:26:49 does this need a virtual destructor?
jam 2012/05/30 14:50:21 yep according to the style guide, i'll add one.
16 public: 16 public:
17 // Notifies that a plugin process has started. 17 // Notifies that a plugin process has started.
18 virtual void PluginProcessStarted(const string16& plugin_name) = 0; 18 virtual void PluginProcessStarted(const string16& plugin_name) {}
19 }; 19 };
20 20
21 } // namespace content 21 } // namespace content
22 22
23 #endif // CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_ 23 #endif // CONTENT_PUBLIC_PLUGIN_CONTENT_PLUGIN_CLIENT_H_
24 24
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698