Issue 10448103: ninja windows: include gyp dir in rc build include dirs

Issue 10448103: ninja windows: include gyp dir in rc build include dirs (Closed)

Created:
8 years, 6 months ago by scottmg

Modified:
8 years, 6 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ninja windows: include gyp dir in rc build include dirs To match VS (and fix some .rc build steps in Chromium targets) BUG=chromium:128729 Committed: https://code.google.com/p/gyp/source/detail?r=1408

Patch Set 1 #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -30 lines)			Patch
M	pylib/gyp/generator/ninja.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pylib/gyp/msvs_emulation.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	test/win/rc-build/hello.gyp	View	1 chunk	+46 lines, -27 lines	2 comments	Download
A	test/win/rc-build/subdir/hello2.rc	View	1 chunk	+87 lines, -0 lines	2 comments	Download
A	test/win/rc-build/subdir/include.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/hello.gyp File test/win/rc-build/hello.gyp (right): https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/hello.gyp#newcode37 test/win/rc-build/hello.gyp:37: 'Culture' : '1033', what does 'Culture' do? sounds ...

8 years, 6 months ago (2012-05-31 19:44:36 UTC) #2

scottmg

8 years, 6 months ago (2012-05-31 20:05:41 UTC) #3

https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/hell...
File test/win/rc-build/hello.gyp (right):

https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/hell...
test/win/rc-build/hello.gyp:37: 'Culture' : '1033',
On 2012/05/31 19:44:36, Nico wrote:
> what does 'Culture' do? sounds hipstery

1033 is great, you probably haven't heard them before.

Codepage/language/something-or-other for en-US. Copied from the Chromium build
files.

https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/subd...
File test/win/rc-build/subdir/hello2.rc (right):

https://chromiumcodereview.appspot.com/10448103/diff/1/test/win/rc-build/subd...
test/win/rc-build/subdir/hello2.rc:23: 
On 2012/05/31 19:44:36, Nico wrote:
> nit: remove 90% of the lines in this file

We had this discussion about hello.rc too :)

It's a generated-by-IDE file so I prefer to leave it as is (so that it's still
IDE editable). Also, I don't really know what a lot of that crud does so I'm not
sure which 90% to delete anyway.

Expand Messages | Collapse Messages