Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: pylib/gyp/generator/ninja.py

Issue 10448103: ninja windows: include gyp dir in rc build include dirs (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | test/win/rc-build/hello.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py
index 0a9394d3f256fa25819089a7d8be516310ead16b..6aa7a68d7a557efdf7c5c3df2aad6b9ebd9e4b1f 100644
--- a/pylib/gyp/generator/ninja.py
+++ b/pylib/gyp/generator/ninja.py
@@ -685,7 +685,8 @@ class NinjaWriter:
if self.flavor == 'win':
self.WriteVariableList('rcflags',
[QuoteShellArgument(self.ExpandSpecial(f), self.flavor)
- for f in self.msvs_settings.GetRcflags(config_name)])
+ for f in self.msvs_settings.GetRcflags(config_name,
+ self.GypPathToNinja)])
include_dirs = config.get('include_dirs', [])
if self.flavor == 'win':
« no previous file with comments | « no previous file | pylib/gyp/msvs_emulation.py » ('j') | test/win/rc-build/hello.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698