Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 10448102: Adds switch to disable generating mouse events from touch events and (Closed)

Created:
8 years, 6 months ago by sky
Modified:
8 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Adds switch to disable generating mouse events from touch events and adds tracking of whether any touch devices are down. I'm going to use the later from Widget. BUG=113279 TEST=none R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139891

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove released and fix bug in GestureRecognizerImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M ui/aura/aura_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/env.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 3 chunks +20 lines, -1 line 0 comments Download
M ui/base/events.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/gestures/gesture_recognizer_impl.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_sequence.h View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
8 years, 6 months ago (2012-05-31 18:17:39 UTC) #1
sadrul
LGTM http://codereview.chromium.org/10448102/diff/1/ui/aura/root_window.cc File ui/aura/root_window.cc (right): http://codereview.chromium.org/10448102/diff/1/ui/aura/root_window.cc#newcode320 ui/aura/root_window.cc:320: touch_ids_down_ = (touch_ids_down_ | (1 << event->touch_id())) ^ ...
8 years, 6 months ago (2012-05-31 18:59:27 UTC) #2
sky
As mentioned in IM I couldn't use a DCHECK since some tests generate events in ...
8 years, 6 months ago (2012-05-31 19:41:44 UTC) #3
sadrul
8 years, 6 months ago (2012-05-31 22:18:29 UTC) #4
LGTM (sorry for the delayed review)

Powered by Google App Engine
This is Rietveld 408576698