Issue 10448055: NaCl: Remove the plugin's internal definition of GetUrandomFD()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10448055: NaCl: Remove the plugin's internal definition of GetUrandomFD() (Closed)

Created:
8 years, 6 months ago by Mark Seaborn

Modified:
8 years, 6 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Remove the plugin's internal definition of GetUrandomFD() The code in the NaCl repo no longer uses this function; it gets a /dev/urandom FD via dependency injection instead. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2655 TEST=nacl_integration etc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139376

Patch Set 1 #

Patch Set 2 : Retry upload #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -30 lines)			Patch
D	ppapi/native_client/src/trusted/plugin/browser_utils.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/module_ppapi.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/nacl_entry_points.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages