NaCl: Remove the plugin's internal definition of GetUrandomFD()

ppapi/native_client/src/trusted/plugin/module_ppapi.cc

 /*
  * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/shared/imc/nacl_imc_c.h"
 #include "native_client/src/shared/platform/nacl_time.h"
 #include "native_client/src/trusted/desc/nrd_all_modules.h"
 #include "native_client/src/trusted/plugin/nacl_entry_points.h"
 #include "native_client/src/trusted/plugin/plugin.h"
 
 #include "ppapi/c/private/ppb_nacl_private.h"
 #include "ppapi/cpp/module.h"
 
-GetURandomFDFunc get_urandom_fd;
-
 namespace plugin {
 
 class ModulePpapi : public pp::Module {
  public:
   ModulePpapi() : pp::Module(),
                   init_was_successful_(false),
                   private_interface_(NULL) {
     MODULE_PRINTF(("ModulePpapi::ModulePpapi (this=%p)\n",
                    static_cast<void*>(this)));
   }
@@ skipping 13 matching lines @@
         GetBrowserInterface(PPB_NACL_PRIVATE_INTERFACE));
 
     if (NULL == private_interface_) {
       MODULE_PRINTF(("ModulePpapi::Init failed: "
                      "GetBrowserInterface returned NULL\n"));
       return false;
     }
 
     launch_nacl_process = reinterpret_cast<LaunchNaClProcessFunc>(
         private_interface_->LaunchSelLdr);
-    // TODO(mseaborn): Remove this get_urandom_fd global variable once
-    // the NaCl side no longer depends on it.
-    get_urandom_fd = private_interface_->UrandomFD;
 
 #if NACL_LINUX || NACL_OSX
+    // Note that currently we do not need random numbers inside the
+    // NaCl trusted plugin on Unix, but NaClSecureRngModuleInit() is
+    // strict and will raise a fatal error unless we provide it with a
+    // /dev/urandom FD beforehand.
     NaClSecureRngModuleSetUrandomFd(dup(private_interface_->UrandomFD()));
 #endif
 
     // In the plugin, we don't need high resolution time of day.
     NaClAllowLowResolutionTimeOfDay();
     NaClNrdAllModulesInit();
     NaClSrpcModuleInit();
 
 #if NACL_WINDOWS && !defined(NACL_STANDALONE)
     NaClSetBrokerDuplicateHandleFunc(private_interface_->BrokerDuplicateHandle);
@@ skipping 24 matching lines @@
 
 
 namespace pp {
 
 Module* CreateModule() {
   MODULE_PRINTF(("CreateModule ()\n"));
   return new plugin::ModulePpapi();
 }
 
 }  // namespace pp