Show only one instance of the keyboard overlay.

Show only one instance of the keyboard overlay.

BUG=129819
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140072

[tfarina, 2012-05-31 21:46:00]

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
File chrome/browser/ui/views/keyboard_overlay_dialog_view.h (right):

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
chrome/browser/ui/views/keyboard_overlay_dialog_view.h:25: void WindowClosing()
OVERRIDE;
nit: missing virtual keyword here.

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
chrome/browser/ui/views/keyboard_overlay_dialog_view.h:30:
DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayDialogView);
nit: private:

[mazda, 2012-05-31 21:58:44]

tfarina,
Thank you for the comments. Addressed them.

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
File chrome/browser/ui/views/keyboard_overlay_dialog_view.h (right):

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
chrome/browser/ui/views/keyboard_overlay_dialog_view.h:25: void WindowClosing()
OVERRIDE;
On 2012/05/31 21:46:01, tfarina wrote:
> nit: missing virtual keyword here.

Done.

http://codereview.chromium.org/10447125/diff/1/chrome/browser/ui/views/keyboa...
chrome/browser/ui/views/keyboard_overlay_dialog_view.h:30:
DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayDialogView);
On 2012/05/31 21:46:01, tfarina wrote:
> nit: private:

Done.

[Ben Goodger (Google), 2012-06-01 17:06:07]

lgtm

[commit-bot: I haz the power, 2012-06-01 17:12:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10447125/8001

[commit-bot: I haz the power, 2012-06-01 17:13:28]

Try job failure for 10447125-8001 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-06-01 17:17:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10447125/8001

[commit-bot: I haz the power, 2012-06-01 19:05:57]

Change committed as 140072