Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 10447013: CL for readability review. (Closed)

Created:
8 years, 7 months ago by falken
Modified:
8 years, 6 months ago
Reviewers:
rpang, Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

[Font Settings API]: CL for readability review. BUG= TEST= TBR=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139746

Patch Set 1 #

Total comments: 14

Patch Set 2 : review comments #

Patch Set 3 : comment for test #

Total comments: 6

Patch Set 4 : review comments #

Patch Set 5 : clarify it's the extension API function name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M chrome/browser/extensions/extension_font_settings_api.h View 1 2 3 4 9 chunks +44 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_apitest.cc View 1 2 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rpang
Some initial comments on the .h file. In general, I've made a specific comment only ...
8 years, 6 months ago (2012-05-29 17:10:16 UTC) #1
falken
Thanks for the review! mpcomplete: Please see question inline at the end. https://chromiumcodereview.appspot.com/10447013/diff/1/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h ...
8 years, 6 months ago (2012-05-30 06:52:15 UTC) #2
rpang
https://chromiumcodereview.appspot.com/10447013/diff/1/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h (right): https://chromiumcodereview.appspot.com/10447013/diff/1/chrome/browser/extensions/extension_font_settings_api.h#newcode16 chrome/browser/extensions/extension_font_settings_api.h:16: class ExtensionFontSettingsEventRouter : public content::NotificationObserver { On 2012/05/30 06:52:16, ...
8 years, 6 months ago (2012-05-30 11:45:51 UTC) #3
Matt Perry
https://chromiumcodereview.appspot.com/10447013/diff/1/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h (right): https://chromiumcodereview.appspot.com/10447013/diff/1/chrome/browser/extensions/extension_font_settings_api.h#newcode66 chrome/browser/extensions/extension_font_settings_api.h:66: virtual ~ClearFontFunction() {} On 2012/05/30 06:52:16, falken wrote: > ...
8 years, 6 months ago (2012-05-30 18:39:05 UTC) #4
falken
Matt, thanks for the RefCounted info. https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h (right): https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h#newcode24 chrome/browser/extensions/extension_font_settings_api.h:24: // ownership of ...
8 years, 6 months ago (2012-05-31 02:38:30 UTC) #5
rpang
lgtm https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h (right): https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h#newcode88 chrome/browser/extensions/extension_font_settings_api.h:88: // clearFont API function. On 2012/05/31 02:38:30, falken ...
8 years, 6 months ago (2012-05-31 02:42:42 UTC) #6
falken
https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h File chrome/browser/extensions/extension_font_settings_api.h (right): https://chromiumcodereview.appspot.com/10447013/diff/5/chrome/browser/extensions/extension_font_settings_api.h#newcode88 chrome/browser/extensions/extension_font_settings_api.h:88: // clearFont API function. On 2012/05/31 02:42:42, rpang wrote: ...
8 years, 6 months ago (2012-05-31 03:34:26 UTC) #7
falken
I'll go ahead and submit this CL now. Does the .cc file look OK too?
8 years, 6 months ago (2012-05-31 03:45:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/10447013/12001
8 years, 6 months ago (2012-05-31 03:45:36 UTC) #9
rpang
LGTM Yes, the .cc file looks fine. - Ruoming On Wed, May 30, 2012 at ...
8 years, 6 months ago (2012-05-31 03:59:54 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-05-31 06:49:54 UTC) #11
Change committed as 139746

Powered by Google App Engine
This is Rietveld 408576698