Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4378)

Unified Diff: chrome/installer/util/browser_distribution.h

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on suffix@r142211 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/browser_distribution.h
diff --git a/chrome/installer/util/browser_distribution.h b/chrome/installer/util/browser_distribution.h
index 8944db98af386e3c52e97785b4eaa6865f772a39..7d02b63f0807bcddbc309da77f8dca4fac8a472c 100644
--- a/chrome/installer/util/browser_distribution.h
+++ b/chrome/installer/util/browser_distribution.h
@@ -67,9 +67,12 @@ class BrowserDistribution {
virtual string16 GetAppGuid();
- // Returns the name by which the program is registered with Default Programs.
- // This is not a localized string suitable for presenting to a user.
- virtual string16 GetApplicationName();
+ // Returns the unsuffixed application name of this program.
+ // This is the base of the name registered with Default Programs on Windows.
+ // IMPORTANT: This should only be called by the installer which needs to make
+ // decisions on the suffixing of the upcoming install, not by external callers
+ // at run-time.
+ virtual string16 GetBaseAppName();
// Returns the localized name of the program.
virtual string16 GetAppShortCutName();
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698