Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: chrome/installer/util/browser_distribution.h

Issue 10446111: Abstract suffixing logic away from GetApplicationName (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on suffix@r142211 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file declares a class that contains various method related to branding. 5 // This file declares a class that contains various method related to branding.
6 6
7 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 7 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
8 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 8 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
9 #pragma once 9 #pragma once
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 static BrowserDistribution* GetSpecificDistribution(Type type); 60 static BrowserDistribution* GetSpecificDistribution(Type type);
61 61
62 Type GetType() const { return type_; } 62 Type GetType() const { return type_; }
63 63
64 virtual void DoPostUninstallOperations(const Version& version, 64 virtual void DoPostUninstallOperations(const Version& version,
65 const FilePath& local_data_path, 65 const FilePath& local_data_path,
66 const string16& distribution_data); 66 const string16& distribution_data);
67 67
68 virtual string16 GetAppGuid(); 68 virtual string16 GetAppGuid();
69 69
70 // Returns the name by which the program is registered with Default Programs. 70 // Returns the unsuffixed application name of this program.
71 // This is not a localized string suitable for presenting to a user. 71 // This is the base of the name registered with Default Programs on Windows.
72 virtual string16 GetApplicationName(); 72 // IMPORTANT: This should only be called by the installer which needs to make
73 // decisions on the suffixing of the upcoming install, not by external callers
74 // at run-time.
75 virtual string16 GetBaseAppName();
73 76
74 // Returns the localized name of the program. 77 // Returns the localized name of the program.
75 virtual string16 GetAppShortCutName(); 78 virtual string16 GetAppShortCutName();
76 79
77 virtual string16 GetAlternateApplicationName(); 80 virtual string16 GetAlternateApplicationName();
78 81
79 virtual string16 GetBrowserAppId(); 82 virtual string16 GetBrowserAppId();
80 83
81 virtual string16 GetInstallSubDir(); 84 virtual string16 GetInstallSubDir();
82 85
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 165
163 const Type type_; 166 const Type type_;
164 167
165 private: 168 private:
166 BrowserDistribution(); 169 BrowserDistribution();
167 170
168 DISALLOW_COPY_AND_ASSIGN(BrowserDistribution); 171 DISALLOW_COPY_AND_ASSIGN(BrowserDistribution);
169 }; 172 };
170 173
171 #endif // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_ 174 #endif // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
OLDNEW
« no previous file with comments | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698