Issue 10446090: Changes the tabstrip dragging code to use coordinates from the events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10446090: Changes the tabstrip dragging code to use coordinates from the events (Closed)

Created:
8 years, 6 months ago by sky

Modified:
8 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Changes the tabstrip dragging code to use coordinates from the events rather than cursor location. This is needed for touch. BUG=113279 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139846

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -101 lines)			Patch
M	chrome/browser/ui/views/tabs/base_tab.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.h	View	8 chunks	+15 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	18 chunks	+64 lines, -74 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm