Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10446068: Merge 139207 - ChromeOS: login: Pass the use-cras option to guest mode. (Closed)

Created:
8 years, 6 months ago by scherkus (not reviewing)
Modified:
8 years, 6 months ago
Reviewers:
dgreid
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 139207 - ChromeOS: login: Pass the use-cras option to guest mode. Pass the --use-cras (kUseCras) option to 'browse as guest' sessions. Before this the guest session would use the alsa plugin. BUG=chromium:129243 TEST=Manual, 'browse as guest', then play audio. Check that the audio server is being used (through logs or clients list in chrome://system). Signed-off-by: Dylan Reid <dgreid@chromium.org>; Review URL: https://chromiumcodereview.appspot.com/10452005 TBR=dgreid@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
8 years, 6 months ago (2012-05-29 20:53:23 UTC) #1
scherkus (not reviewing)
8 years, 6 months ago (2012-05-29 20:53:58 UTC) #2
TBR=dgreid

Powered by Google App Engine
This is Rietveld 408576698