Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 10452005: ChromeOS: login: Pass the use-cras option to guest mode. (Closed)

Created:
8 years, 7 months ago by dgreid
Modified:
8 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

ChromeOS: login: Pass the use-cras option to guest mode. Pass the --use-cras (kUseCras) option to 'browse as guest' sessions. Before this the guest session would use the alsa plugin. BUG=chromium:129243 TEST=Manual, 'browse as guest', then play audio. Check that the audio server is being used (through logs or clients list in chrome://system). Signed-off-by: Dylan Reid <dgreid@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139207

Patch Set 1 #

Patch Set 2 : Only pass cras flag when using cras. #

Patch Set 3 : Relocate kUseCras to chroem_switches. #

Patch Set 4 : Add dep for media_switches to browser/chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dgreid
Also addresses crosbug.com/31211
8 years, 7 months ago (2012-05-24 03:40:40 UTC) #1
no longer working on chromium
On 2012/05/24 03:40:40, dgreid wrote: > Also addresses crosbug.com/31211 lgtm
8 years, 7 months ago (2012-05-24 07:24:11 UTC) #2
scherkus (not reviewing)
lgtm -- you still may need an OWNERS
8 years, 7 months ago (2012-05-24 17:29:40 UTC) #3
dgreid
add more owners.
8 years, 7 months ago (2012-05-24 17:35:04 UTC) #4
whywhat
lgtm
8 years, 7 months ago (2012-05-24 17:36:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgreid@chromium.org/10452005/1
8 years, 7 months ago (2012-05-24 17:43:28 UTC) #6
commit-bot: I haz the power
Try job failure for 10452005-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-24 18:10:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgreid@chromium.org/10452005/1
8 years, 7 months ago (2012-05-24 20:14:41 UTC) #8
commit-bot: I haz the power
Try job failure for 10452005-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-24 20:40:38 UTC) #9
dgreid
Slight modification to only pass this flag when the build has CRAS in it (which ...
8 years, 7 months ago (2012-05-25 17:12:24 UTC) #10
scherkus (not reviewing)
still lgtm
8 years, 7 months ago (2012-05-25 17:32:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgreid@chromium.org/10452005/1003
8 years, 7 months ago (2012-05-25 17:37:35 UTC) #12
commit-bot: I haz the power
Try job failure for 10452005-1003 (retry) on mac_rel for step "check_deps". It's a second try, ...
8 years, 7 months ago (2012-05-25 18:20:17 UTC) #13
dgreid
Now it doesn't like my including a media file from here. That makes sense. Would ...
8 years, 7 months ago (2012-05-25 18:54:13 UTC) #14
whywhat
Sounds good. I think we mostly have all Chrome switches in one or two places. ...
8 years, 7 months ago (2012-05-25 18:57:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgreid@chromium.org/10452005/14003
8 years, 6 months ago (2012-05-27 00:49:25 UTC) #16
commit-bot: I haz the power
8 years, 6 months ago (2012-05-27 02:07:01 UTC) #17
Change committed as 139207

Powered by Google App Engine
This is Rietveld 408576698