Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/compiler/buildbot.py

Issue 10446060: Use drt instead of chrome in dart2js/chrome/linux. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/buildbot.py
===================================================================
--- utils/compiler/buildbot.py (revision 8058)
+++ utils/compiler/buildbot.py (working copy)
@@ -189,6 +189,12 @@
# http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
flags = flags + ['-j1']
+ if system == 'linux' and runtime == 'chrome':
+ # TODO(efortuna): Move back to DumpRenderTree when we have a more stable
kasperl 2012/05/29 14:06:45 I don't understand the comment at all.
ngeoffray 2012/05/29 14:10:56 :) Removed and updated to make sure we install sel
+ # solution for DRT. Right now DRT is flakier than regular Chrome for the
+ # isolate tests, so we're switching to use Chrome in the short term.
+ runtime = 'drt'
+
if compiler == 'dart2js':
if option == 'checked': flags = flags + ['--host-checked']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698