Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: utils/compiler/buildbot.py

Issue 10446060: Use drt instead of chrome in dart2js/chrome/linux. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Dart frog buildbot steps 7 """Dart frog buildbot steps
8 8
9 Runs tests for the frog or dart2js compiler. 9 Runs tests for the frog or dart2js compiler.
10 """ 10 """
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 # Make sure we are in the frog directory 183 # Make sure we are in the frog directory
184 os.chdir(DART_PATH) 184 os.chdir(DART_PATH)
185 185
186 if system.startswith('win') and runtime == 'ie': 186 if system.startswith('win') and runtime == 'ie':
187 # There should not be more than one InternetExplorerDriver instance 187 # There should not be more than one InternetExplorerDriver instance
188 # running at a time. For details, see 188 # running at a time. For details, see
189 # http://code.google.com/p/selenium/wiki/InternetExplorerDriver. 189 # http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
190 flags = flags + ['-j1'] 190 flags = flags + ['-j1']
191 191
192 if system == 'linux' and runtime == 'chrome':
193 # TODO(efortuna): Move back to DumpRenderTree when we have a more stable
kasperl 2012/05/29 14:06:45 I don't understand the comment at all.
ngeoffray 2012/05/29 14:10:56 :) Removed and updated to make sure we install sel
194 # solution for DRT. Right now DRT is flakier than regular Chrome for the
195 # isolate tests, so we're switching to use Chrome in the short term.
196 runtime = 'drt'
197
192 if compiler == 'dart2js': 198 if compiler == 'dart2js':
193 if option == 'checked': flags = flags + ['--host-checked'] 199 if option == 'checked': flags = flags + ['--host-checked']
194 200
195 if runtime == 'd8': 201 if runtime == 'd8':
196 # The dart2js compiler isn't self-hosted (yet) so we run its 202 # The dart2js compiler isn't self-hosted (yet) so we run its
197 # unit tests on the VM. We avoid doing this on the builders 203 # unit tests on the VM. We avoid doing this on the builders
198 # that run the browser tests to cut down on the cycle time. 204 # that run the browser tests to cut down on the cycle time.
199 TestStep("dart2js_unit", mode, system, 'none', 'vm', ['leg'], flags) 205 TestStep("dart2js_unit", mode, system, 'none', 'vm', ['leg'], flags)
200 206
201 # Run the default set of test suites. 207 # Run the default set of test suites.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 if status == 0 and compiler != 'dart2js': 286 if status == 0 and compiler != 'dart2js':
281 status = TestCompiler(compiler, runtime, mode, system, option, 287 status = TestCompiler(compiler, runtime, mode, system, option,
282 test_flags + ['--checked']) 288 test_flags + ['--checked'])
283 289
284 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime) 290 if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
285 if status != 0: print '@@@STEP_FAILURE@@@' 291 if status != 0: print '@@@STEP_FAILURE@@@'
286 return status 292 return status
287 293
288 if __name__ == '__main__': 294 if __name__ == '__main__':
289 sys.exit(main()) 295 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698