Issue 10445025: GetAllSavableResourceLinksForCurrentPage shouldn't be permitted to modify the array of savable sche…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10445025: GetAllSavableResourceLinksForCurrentPage shouldn't be permitted to modify the array of savable sche… (Closed)

Created:
8 years, 7 months ago by grt (UTC plus 2)

Modified:
7 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

GetAllSavableResourceLinksForCurrentPage shouldn't be permitted to modify the array of savable schemes. BUG=none TEST=none

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/dom_operations.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/dom_operations.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

grt (UTC plus 2)

Hi James, This change just tweaks the const-ness of the savable schemes array so I ...

8 years, 7 months ago (2012-05-25 02:25:47 UTC) #2

jamesr

8 years, 7 months ago (2012-05-25 21:05:40 UTC) #3

is there no better type? what about base::StringPiece or a real vector of
strings?