Escape search terms correctly in the path portion of a custom search engine.

Escape search terms correctly in the path portion of a custom search engine.

This regressed with the fix for bug 111923.  This attempts to correct the problem without breaking that bug, which requires being able to encode path components using arbitrary encodings.

This also eliminates a variety of functions as cleanup:
  * BrowserAccessibilityWin::Escape(); this was not actually used.
  * The 4-arg form of EscapeQueryParamValue(); only template_url.cc used this, and the necessary implementation can just move there.
  * EscapeQueryParamValueUTF8(); the few remaining callers using that can just manually convert on the caller side.

BUG=127475
TEST=Create custom search engine with url "http://google.com/%s", try using your custom engine to search for "foo/bar", and make sure you wind up at "google.com/foo/bar" and not "google.com/foo%2Fbar"
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139929

[Peter Kasting, 2012-05-31 20:33:12]

sky: chrome/browser/search_engines
dmazzoni: content/browser/accessibility
brettw: net/base
willchan: net/base OWNERS

(bashi: FYI)

Brett, I'm also concerned about how EscapeQueryParamValue() is "deprecated" in
escape.h, and escape_icu.cc has a comment referring to a buganizer bug that you
marked Fixed a while ago.  For the first, I'm wondering whether the callers
should be using something else instead; for the second, I'm not sure what should
happen (just remove the comment?).

[brettw, 2012-05-31 20:57:08]

net LGTM. I think we should just remove the "deprecated" comment

[willchan no longer on Chromium, 2012-05-31 21:01:54]

net/ LGTM

[sky, 2012-05-31 21:07:08]

LGTM

[dmazzoni, 2012-05-31 21:12:25]

Actually it looks like browser_accessibility_win.cc doesn't need Escape anymore
- the only calls to it were removed in r99161 and I don't anticipate needing
them again. Please just delete Escape from browser_accessibility_win.h and
browser_accessibility_win.cc - thanks!

[Peter Kasting, 2012-05-31 23:03:42]

On 2012/05/31 21:12:25, Dominic Mazzoni wrote:
> Please just delete Escape from browser_accessibility_win.h and
> browser_accessibility_win.cc - thanks!

Done; PTAL.

Also removed a bunch of stuff from escape.[cc,h] after discussion over IM with
brettw.  I'm not going to wait for anyone to look at that stuff again; just an
FYI.

[willchan no longer on Chromium, 2012-05-31 23:13:43]

SGTM

On Thu, May 31, 2012 at 4:03 PM, <pkasting@chromium.org> wrote:

> On 2012/05/31 21:12:25, Dominic Mazzoni wrote:
>
>> Please just delete Escape from browser_accessibility_win.h and
>> browser_accessibility_win.cc - thanks!
>>
>
> Done; PTAL.
>
> Also removed a bunch of stuff from escape.[cc,h] after discussion over IM
> with
> brettw.  I'm not going to wait for anyone to look at that stuff again;
> just an
> FYI.
>
>
http://codereview.chromium.**org/10444117/<http://codereview.chromium.org/104...
>

[dmazzoni, 2012-05-31 23:25:50]

lgtm for accessibility, thanks