Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: net/base/escape_icu.cc

Issue 10444117: Escape search terms correctly in the path portion of a custom search engine. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/escape.cc ('k') | net/base/escape_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/escape_icu.cc
===================================================================
--- net/base/escape_icu.cc (revision 139570)
+++ net/base/escape_icu.cc (working copy)
@@ -1,29 +0,0 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/base/escape.h"
-
-#include "base/i18n/icu_string_conversions.h"
-#include "base/utf_string_conversions.h"
-
-// This file exists to avoid having escape.cc depend on ICU.
-
-namespace net {
-
-bool EscapeQueryParamValue(const string16& text,
- const char* codepage,
- bool use_plus,
- string16* escaped) {
- // TODO(brettw) bug 1201094: this function should be removed, this "SKIP"
- // behavior is wrong when the character can't be encoded properly.
- std::string encoded;
- if (!base::UTF16ToCodepage(text, codepage,
- base::OnStringConversionError::SKIP, &encoded))
- return false;
-
- escaped->assign(UTF8ToUTF16(EscapeQueryParamValue(encoded, use_plus)));
- return true;
-}
-
-} // namespace net
« no previous file with comments | « net/base/escape.cc ('k') | net/base/escape_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698