Aura: add a bench utility

Aura: add a bench utility

This utility lets us experiment with and benchmark various layer configurations.
It has 2 builtin benchmarks:
- a webgl benchmark (intended to model the layer tree used when hooking up webgl)
- a slow-scroll benchmark (intended to model a non-accelerated scroll)

BUG=None
TEST=self


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139160

[piman, 2012-05-25 04:25:29]

note, this needs https://bugs.webkit.org/show_bug.cgi?id=87436 to land and roll
first

[sky, 2012-05-25 15:30:42]

Just nits except for questions about the postTask.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
File ui/aura/bench/bench_main.cc (right):

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:30: #include
"third_party/WebKit/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h"
nit: sort

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:58: virtual ~ColoredLayer() { }
nit: { } -> {}

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:76: };
DISALLOW_... (here and all classes you're creating)

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:88: virtual void OnCompositingStarted(Compositor*
compositor) {}
OVERRIDE (here and 90)

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:105: MessageLoop::current()->PostTask(
Why do you need this? And how to you guarantee this object is around when the
task is processed?

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:203: virtual void Draw() {
OVERRIDE

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:221: unsigned int fbo_;
How about a description of fbo_ and do_draw_ ?

[piman, 2012-05-25 22:11:28]

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
File ui/aura/bench/bench_main.cc (right):

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:30: #include
"third_party/WebKit/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h"
On 2012/05/25 15:30:42, sky wrote:
> nit: sort

Done.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:58: virtual ~ColoredLayer() { }
On 2012/05/25 15:30:42, sky wrote:
> nit: { } -> {}

Done.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:76: };
On 2012/05/25 15:30:42, sky wrote:
> DISALLOW_... (here and all classes you're creating)

Done.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:88: virtual void OnCompositingStarted(Compositor*
compositor) {}
On 2012/05/25 15:30:42, sky wrote:
> OVERRIDE (here and 90)

Done.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:105: MessageLoop::current()->PostTask(
On 2012/05/25 15:30:42, sky wrote:
> Why do you need this? And how to you guarantee this object is around when the
> task is processed?

There was a bug that prevented ScheduleDraw from working when called from
OnCompositingEnded in the in-process GL case. I fixed that.
FTR lifetime was ok since this class outlives the MessageLoop::Run() (and,
separately, doesn't have any pending task after it calls Quit).

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:203: virtual void Draw() {
On 2012/05/25 15:30:42, sky wrote:
> OVERRIDE

Done.

https://chromiumcodereview.appspot.com/10444019/diff/1/ui/aura/bench/bench_ma...
ui/aura/bench/bench_main.cc:221: unsigned int fbo_;
On 2012/05/25 15:30:42, sky wrote:
> How about a description of fbo_ and do_draw_ ?

Done.

[sky, 2012-05-25 22:12:48]

LGTM

[commit-bot: I haz the power, 2012-05-25 22:15:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/10444019/5001

[commit-bot: I haz the power, 2012-05-26 00:07:22]

Change committed as 139160