Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(36)

Issue 10444013: Merge 117191 - Assertion failure running Mozilla's WebGL performance regression tests (Closed)

Created:
7 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 117191 - Assertion failure running Mozilla's WebGL performance regression tests https://bugs.webkit.org/show_bug.cgi?id=85942 Reviewed by Stephen White. Fixed incorrect assumptions about source formats and buffer sizes when uploading to floating-point textures. Added code paths supporting the necessary conversions. Tests have been added to the WebGL conformance suite which cover these new code paths; they verify uploads of HTMLCanvasElement, HTMLImageElement, HTMLVideoElement, and ImageData to floating-point textures. However, because floating-point texture support is optional, and generally only supported on bots which run with real GPUs and not in virtual machines, it isn't feasible to incorporate these tests as layout tests. Ran the new WebGL conformance tests in Chromium on Linux; all pass. * platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Properly compute size of destination buffer. (WebCore): Add pack/unpack routines for converting RGBA8/BGRA8 to floating point. (WebCore::doFloatingPointPacking): Support RGBA8 and BGRA8 source formats. (WebCore::isFloatingPointSource): Factored out logic for assertions. (WebCore::GraphicsContext3D::packPixels): Generalized assertions and logic. * platform/graphics/cairo/GraphicsContext3DCairo.cpp: (WebCore::GraphicsContext3D::getImageData): Properly compute size of destination buffer. * platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Properly compute size of destination buffer. * platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData): Properly compute size of destination buffer. * platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): Properly compute size of destination buffer. TBR=kbr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -26 lines) Patch
M Source/WebCore/platform/graphics/GraphicsContext3D.cpp View 12 chunks +156 lines, -22 lines 0 comments Download
M Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 5 months ago (2012-05-24 20:37:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698