Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp

Issue 10444013: Merge 117191 - Assertion failure running Mozilla's WebGL performance regression tests (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp
===================================================================
--- Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp (revision 118409)
+++ Source/WebCore/platform/graphics/skia/GraphicsContext3DSkia.cpp (working copy)
@@ -79,7 +79,11 @@
const SkBitmap& skiaImageRef = skiaImage->bitmap();
SkAutoLockPixels lock(skiaImageRef);
ASSERT(skiaImageRef.rowBytes() == skiaImageRef.width() * 4);
- outputVector.resize(skiaImageRef.rowBytes() * skiaImageRef.height());
+ unsigned int packedSize;
+ // Output data is tightly packed (alignment == 1).
+ if (computeImageSizeInBytes(format, type, skiaImageRef.width(), skiaImageRef.height(), 1, &packedSize, 0) != GraphicsContext3D::NO_ERROR)
+ return false;
+ outputVector.resize(packedSize);
return packPixels(reinterpret_cast<const uint8_t*>(skiaImageRef.getPixels()),
SK_B32_SHIFT ? SourceFormatRGBA8 : SourceFormatBGRA8,
skiaImageRef.width(), skiaImageRef.height(), 0,
« no previous file with comments | « Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698